ReferenceCounterV2

[shargon]

Description

Close #3517

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• UT_ReferenceCounterV2

Test Configuration:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[Jim8y]

its not yet being used right, no wander the bench has no change.

[shargon]

its not yet being used right, no wander the bench has no change.

No, if you like it, i can start with the selection according to the height

[Jim8y]

its not yet being used right, no wander the bench has no change.

No, if you like it, i can start with the selection according to the height

I could not really understand the reason of this pr, but after i replace RC with this version, optimization for some pocs are obvious, but for the rest is not that clear:

V1

// | Method | Mean | Error | StdDev | Median |
// |----------------------- |----------------:|---------------:|---------------:|----------------:|
// | NeoIssue2528 | 672,995.40 us | 13,240.184 us | 21,754.002 us | 666,763.00 us |
// | NeoVMIssue418 | 574.74 us | 11.179 us | 11.480 us | 572.26 us |
// | NeoIssue2723 | 68.45 us | 0.968 us | 0.906 us | 68.21 us |
// | PoC_NewBuffer | 68.04 us | 1.078 us | 1.008 us | 67.75 us |
// | PoC_Cat | 68.29 us | 1.143 us | 1.069 us | 67.82 us |
// | PoC_Left | 65.79 us | 0.678 us | 0.634 us | 65.78 us |
// | PoC_Right | 68.19 us | 0.777 us | 0.727 us | 67.88 us |
// | PoC_ReverseN | 8,317,148.36 us | 26,176.966 us | 20,437.254 us | 8,311,623.35 us |
// | PoC_Substr | 67.13 us | 0.641 us | 0.600 us | 67.05 us |
// | PoC_NewArray | 4,016,079.05 us | 48,575.705 us | 45,437.745 us | 4,007,341.40 us |
// | PoC_NewStruct | 4,713,414.06 us | 41,234.516 us | 34,432.688 us | 4,706,219.60 us |
// | PoC_Roll | 1,248,732.44 us | 13,837.434 us | 12,943.545 us | 1,246,873.10 us |
// | PoC_XDrop | 2,367,151.97 us | 131,814.326 us | 388,657.514 us | 2,503,579.05 us |
// | PoC_MemCpy | 106.51 us | 6.273 us | 18.495 us | 113.14 us |
// | PoC_Unpack | 677,618.41 us | 41,248.471 us | 121,622.047 us | 727,964.25 us |
// | PoC_GetScriptContainer | 64.84 us | 1.055 us | 0.987 us | 65.01 us |

V2

// | Method | Mean | Error | StdDev |
// |----------------------- |----------------:|--------------:|--------------:|
// | NeoIssue2528 | 8,057.26 us | 115.627 us | 108.158 us |
// | NeoVMIssue418 | 288.69 us | 3.035 us | 2.839 us |
// | NeoIssue2723 | 69.08 us | 0.629 us | 0.588 us |
// | PoC_NewBuffer | 67.75 us | 0.873 us | 0.816 us |
// | PoC_Cat | 67.80 us | 0.779 us | 0.729 us |
// | PoC_Left | 68.20 us | 0.688 us | 0.644 us |
// | PoC_Right | 66.33 us | 0.684 us | 0.640 us |
// | PoC_ReverseN | 8,247,475.45 us | 23,815.937 us | 22,277.442 us |
// | PoC_Substr | 67.38 us | 0.792 us | 0.703 us |
// | PoC_NewArray | 79.21 us | 0.990 us | 0.926 us |
// | PoC_NewStruct | 85.20 us | 1.249 us | 1.169 us |
// | PoC_Roll | 1,188,522.22 us | 7,654.767 us | 6,785.751 us |
// | PoC_XDrop | 1,185,929.37 us | 16,518.830 us | 15,451.724 us |
// | PoC_MemCpy | 67.03 us | 1.163 us | 1.088 us |
// | PoC_Unpack | 216,052.64 us | 3,346.821 us | 3,130.618 us |
// | PoC_GetScriptContainer | 66.20 us | 0.675 us | 0.632 us |

[shargon]

Is not possible to be slower than the previous case in any of them xD