-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6R2yEhGU] No procedure with name xxxx registered for this database instance #3800
Conversation
dd5fbec
to
65753c8
Compare
@@ -55,7 +58,7 @@ | |||
public class CypherProceduresStorageTest { | |||
private final static String QUERY_CREATE = "RETURN $input1 + $input2 as answer"; | |||
private final static String QUERY_OVERWRITE = "RETURN $input1 + $input2 + 123 as answer"; | |||
private final int refreshTime = 3000; | |||
private final int refreshTime = 50; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the *WorksCorrectlyWithoutConflicts()
tests more deterministic, since the bug occurs when calling a custom procedure/function during the refresh phase.
With a high refreshTime
the tests are almost always green even without the synchronized
clauses.
65753c8
to
21ef567
Compare
21ef567
to
ad0d62e
Compare
…nstance (#3800) * [6R2yEhGU] No procedure with name xxxx registered for this database instance * [6R2yEhGU] added testCallEventually
…nstance (neo4j-contrib#3800) * [6R2yEhGU] No procedure with name xxxx registered for this database instance * [6R2yEhGU] added testCallEventually
…nstance (#3800) * [6R2yEhGU] No procedure with name xxxx registered for this database instance * [6R2yEhGU] added testCallEventually
Steps to reproduce
Create multiple procs/overrides with low refresh config value (e.g.:
apoc.custom.procedures.refresh=10
)Why
Sometimes it can happen that during the refresh the system database has discrepancies with the cache (i.e.
registeredProcedureSignatures
andregisteredUserFunctionSignatures
) and therefore some procedures/functions are mistakenly de-registered.synchronized
inrestoreProceduresAndFunctions
,storeFunction
andstoreProcedure
methods