Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Fix wrong primary key being used in update and merge mutation #378

Closed
wants to merge 1 commit into from
Closed

Fix wrong primary key being used in update and merge mutation #378

wants to merge 1 commit into from

Conversation

ChristiaanScheermeijer
Copy link
Contributor

Hi,

The update, merge and delete mutations used the first argument as the primary key in the cypher query. This will result in unexpected behaviour and can wipe your data in a worst-case scenario.

Given the following schema:

type Person {
  place: String!
  name: String
  id: ID
}

In the cypher query, the node selection uses the place argument. Which in this case, can be multiple nodes.

Happy to hear your feedback!

@codecov-io
Copy link

codecov-io commented Jan 14, 2020

Codecov Report

Merging #378 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   96.55%   96.55%   +<.01%     
==========================================
  Files          24       24              
  Lines        2846     2848       +2     
==========================================
+ Hits         2748     2750       +2     
  Misses         98       98
Impacted Files Coverage Δ
src/utils.js 94.53% <100%> (+0.02%) ⬆️
src/translate.js 98.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e16662...a6db126. Read the comment docs.

@michaeldgraham
Copy link
Collaborator

#608

@Videodock Videodock closed this by deleting the head repository Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants