fix: Double results when iterating after deserialization

neo4j-php · Aug 9, 2024 · 108ccb6 · 108ccb6
1 parent 7681d10
commit 108ccb6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Types/AbstractCypherSequence.php b/src/Types/AbstractCypherSequence.php
@@ -564,7 +564,7 @@ public function __serialize(): array
         $this->preload();
 
         $tbr = get_object_vars($this);
-        $tbr['generator'] = new ArrayIterator($this->cache);
+        $tbr['generator'] = new ArrayIterator();
         $tbr['currentPosition'] = 0;
         $tbr['generatorPosition'] = 0;
 

diff --git a/tests/Unit/CypherListTest.php b/tests/Unit/CypherListTest.php
@@ -47,6 +47,21 @@ public function setUp(): void
         $this->list = new CypherList(['A', 'B', 'C']);
     }
 
+    // https://github.com/neo4j-php/neo4j-php-client/issues/220
+    public function testNoDoubleResultsAfterDeserialization(): void
+    {
+        $list = new CypherList(['A', 'B', 'C']);
+        $serialized = serialize($list);
+        $unserialized = unserialize($serialized);
+
+        $count = 0;
+        foreach ($unserialized as $item) {
+            ++$count;
+        }
+
+        self::assertEquals(3, $count);
+    }
+
     public function testFromIterableEqual(): void
     {
         $fromIterable = CypherList::fromIterable($this->list);