fix http tests

neo4j-php · Oct 9, 2024 · 8594be4 · 8594be4
1 parent 17725dc
commit 8594be4
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/src/Http/HttpHelper.php b/src/Http/HttpHelper.php
@@ -49,7 +49,7 @@ final class HttpHelper
      */
     public static function interpretResponse(ResponseInterface $response): stdClass
     {
-        if ($response->getStatusCode() >= 400) {
+        if ($response->getStatusCode() >= 500) {
             throw new RuntimeException('HTTP Error: '.$response->getReasonPhrase());
         }
 

diff --git a/tests/Integration/SummarizedResultFormatterTest.php b/tests/Integration/SummarizedResultFormatterTest.php
@@ -104,6 +104,10 @@ public function testAvailableAfter(): void
 
     public function testDateTime(): void
     {
+        if (str_starts_with($_ENV['CONNECTION'] ?? '', 'http')) {
+            $this->markTestSkipped('http does not support datetime conversion');
+        }
+
         $dt = new DateTimeImmutable();
         $ls = $this->getSession()->run('RETURN $x AS x', ['x' => $dt])->first()->get('x');
 

diff --git a/tests/Integration/TransactionIntegrationTest.php b/tests/Integration/TransactionIntegrationTest.php
@@ -226,10 +226,15 @@ public function testCommitInvalid(): void
         $exception = null;
         try {
             $tsx->commit();
-        } catch (ClientException $e) {
+        } catch (ClientException|Neo4jException $e) {
             $exception = $e;
         }
-        self::assertTrue($exception instanceof ClientException);
+
+        if (str_starts_with($_ENV['CONNECTION'] ?? '', 'http')) {
+            self::assertTrue($exception instanceof Neo4jException);
+        } else {
+            self::assertTrue($exception instanceof ClientException);
+        }
 
         self::assertTrue($tsx->isFinished());
         self::assertFalse($tsx->isRolledBack());
@@ -259,10 +264,15 @@ public function testRollbackInvalid(): void
         $exception = null;
         try {
             $tsx->rollback();
-        } catch (ClientException $e) {
+        } catch (ClientException|Neo4jException $e) {
             $exception = $e;
         }
-        self::assertTrue($exception instanceof ClientException);
+
+        if (str_starts_with($_ENV['CONNECTION'] ?? '', 'http')) {
+            self::assertTrue($exception instanceof Neo4jException);
+        } else {
+            self::assertTrue($exception instanceof ClientException);
+        }
 
         self::assertTrue($tsx->isFinished());
         self::assertTrue($tsx->isRolledBack());