-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update psr/http-message ^2.0 & add ext-mbstring & update stefanak-michal/bolt ^5.1 -> ^6.0 #196
Conversation
When I use it for symfony 6.4 it need psr/http-message ^2.0 |
@@ -24,7 +24,7 @@ | |||
"php": "^8.0", | |||
"laudis/typed-enum": "^1.3.2", | |||
"php-http/discovery": "^1.13", | |||
"psr/http-message": "^1.0", | |||
"psr/http-message": "^1.0|^2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to keep the old version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say so yes to maintain backwards compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your project is php^8 and with the change 1.1 to 2.0 ( php-fig/http-message@1.1...2.0 ) you have nothing to worry about. It's just added argument types and return types.
Thank you for the update! I'll be running some test and merge it later today. Good job! |
I'm not sureneed to add constraints,
although Blot already has constraints, |
I think https://github.com/neo4j-php/Bolt/releases/tag/v6.0.0 I'd like PHP's version constraints to be consistent. |
If you are updating more than psr/http-message you should update PR name. |
I update the PR name, thx. |
@transistive If you have time to deal with this PR, my team and I urgently need to update a version. |
update psr/http-message ^2.0