Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update psr/http-message ^2.0 & add ext-mbstring & update stefanak-michal/bolt ^5.1 -> ^6.0 #196

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

lcp0578
Copy link
Contributor

@lcp0578 lcp0578 commented Feb 23, 2024

update psr/http-message ^2.0

@lcp0578
Copy link
Contributor Author

lcp0578 commented Feb 23, 2024

When I use it for symfony 6.4 it need psr/http-message ^2.0

@@ -24,7 +24,7 @@
"php": "^8.0",
"laudis/typed-enum": "^1.3.2",
"php-http/discovery": "^1.13",
"psr/http-message": "^1.0",
"psr/http-message": "^1.0|^2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to keep the old version?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say so yes to maintain backwards compatibility

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your project is php^8 and with the change 1.1 to 2.0 ( php-fig/http-message@1.1...2.0 ) you have nothing to worry about. It's just added argument types and return types.

@transistive
Copy link
Collaborator

Thank you for the update! I'll be running some test and merge it later today. Good job!

@lcp0578
Copy link
Contributor Author

lcp0578 commented Feb 23, 2024

I'm not sureneed to add constraints,

"ext-mbstring": "*"

although Blot already has constraints,
https://github.com/neo4j-php/Bolt/blob/master/composer.json#L12
but when I require this libraries, composer didn't tell me that I needed mbstring extensions, which really wasted a lot of my time, and I found out through debugging that I really didn't have it, but it's not so intuitive, and I hope it will reduce the time of other people who use this library.

@lcp0578
Copy link
Contributor Author

lcp0578 commented Feb 23, 2024

I think
"php": "^8.0",
https://github.com/neo4j-php/neo4j-php-client/blob/main/composer.json#L24
so,
image

https://github.com/neo4j-php/Bolt/releases/tag/v6.0.0

I'd like PHP's version constraints to be consistent.

@stefanak-michal
Copy link
Contributor

If you are updating more than psr/http-message you should update PR name.

@lcp0578 lcp0578 changed the title update psr/http-message ^2.0 update psr/http-message ^2.0 & add ext-mbstring & update stefanak-michal/bolt ^5.1 -> ^6.0 Feb 23, 2024
@lcp0578
Copy link
Contributor Author

lcp0578 commented Feb 23, 2024

If you are updating more than psr/http-message you should update PR name.

I update the PR name, thx.

@lcp0578
Copy link
Contributor Author

lcp0578 commented Feb 26, 2024

@transistive If you have time to deal with this PR, my team and I urgently need to update a version.

@transistive transistive merged commit 5a62778 into neo4j-php:main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants