Should "diagnostic.separateRelatedInformationAsDiagnostics" feature be implemented by coc client rather than LS?

[hexh250786313]

"Related diagnostics:" message not showed in coc-tsserver because coc-tsserver doesn't implement the "diagnostic.separateRelatedInformationAsDiagnostics" feature. I think this feature should be implemented in the public diagnostic/collection.ts rather than LS itself.

Any suggestions?

[fannheyward]

because coc-tsserver doesn't implement

does tsserver returns diagnostic.relatedInformation?

[hexh250786313]

Yes, it returns.

Coc.nvim implements this feature for all LS configured in "languageserver". But for standalone LS extension, it depends on whether the extension itself implements this feature or not.

coc.nvim/src/language-client/client.ts

Lines 1580 to 1596 in a00ff12

	if (separate && diagnostics.length > 0) {
	const entries: Map<string, Diagnostic[]> = new Map()
	entries.set(uri, diagnostics)
	for (const diagnostic of diagnostics) {
	if (diagnostic.relatedInformation?.length) {
	let message = `${diagnostic.message}\n\nRelated diagnostics:\n`
	for (const info of diagnostic.relatedInformation) {
	const basename = path.basename(URI.parse(info.location.uri).fsPath)
	const ln = info.location.range.start.line
	message = `${message}\n${basename}(line ${ln + 1}): ${info.message}`
	const diags: Diagnostic[] = entries.get(info.location.uri) || []
	diags.push(Diagnostic.create(info.location.range, info.message, DiagnosticSeverity.Hint, diagnostic.code, diagnostic.source))
	entries.set(info.location.uri, diags)
	}
	diagnostic.message = message
	}