Update srgutils to 0.5.3 #3
Conversation
| @@ -61,7 +61,7 @@ license { | |||
|
|
|||
| dependencies { | |||
| implementation 'net.sf.jopt-simple:jopt-simple:6.0-alpha-3' | |||
| api 'net.minecraftforge:srgutils:0.5.1' | |||
| api 'net.minecraftforge:srgutils:0.5.3' | |||
There was a problem hiding this comment.
Any update should use the neoforge version, not the one from Forge.
The latest version of that is net.neoforged:srgutils:1.0.0.
Why are you updating to 0.5.3 of the Forge version? What feature/bugfix is the trigger here?
There was a problem hiding this comment.
Mostly just for the microoptimizations in hot methods (removing streams). If a PR going beyond what Forge did (while still pretty much just being microoptimizations) would be accepted, I'd make a PR to your version of it, or just in general some of the hard to read stream code that would honestly look better with plain old loops due to the way they were written here. (As silly as that might be, doing that and some other small changes would actually have a mildly noticeable impact on the scale that we are using this)
No description provided.