Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove final from instanceof check in Config #26

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Remove final from instanceof check in Config #26

merged 1 commit into from
Dec 9, 2023

Conversation

TelepathicGrunt
Copy link

Eclipse reaaaally hates this final here and it looks weird to the rest of us. Since the MDK should work for all IDEs. we should remove that final.

@TelepathicGrunt
Remove final from instanceof check in Config
fc8d4a3 
Eclipse reaaaally hates this `final` here and it looks weird to the rest of us. Since the MDK should work for all IDEs. we should remove that `final`.
embeddedt
embeddedt approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing gained by having this here except making the code harder to read.

@sciwhiz12
Copy link
Member

I'll say, this is the first time I've ever seen a final modifier in a pattern-matching instanceof. 😄

@sciwhiz12 sciwhiz12 added the enhancement New feature or request label Dec 9, 2023
@sciwhiz12 sciwhiz12 merged commit f5f4fec into neoforged:main Dec 9, 2023
1 check passed
@TelepathicGrunt TelepathicGrunt deleted the patch-2 branch May 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embeddedt embeddedt embeddedt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TelepathicGrunt @sciwhiz12 @embeddedt