Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FML / ModLauncher (Updates Mixin, Improved Error Reporting, Addresses Log4j2 Warnings) #1230

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Jul 4, 2024

Please note that some of the changes to gradle.properties are to bring it in line with newer transitive dependencies that come in from FML.

The PR includes the following upstream changes:
McModLauncher/modlauncher#129 [Remove package scanning in log4j2 configuration]
neoforged/FancyModLoader#173 [Updated Mixin]
neoforged/FancyModLoader#170 [Better error reporting in dev]
neoforged/FancyModLoader#174 [Bump TerminalConsoleAppender]
neoforged/FancyModLoader#167 [Refactor ModLoadingIssue Warning/Error Translations]
neoforged/FancyModLoader#164 [Remove unnecessary IConfigEvent and ConfigConfig]

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 4, 2024

  • Publish PR to GitHub Packages

Last commit published: e922e6aa3074f5925e66a978bdf52aa12e7cddc2.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1230' // https://github.com/neoforged/NeoForge/pull/1230
        url 'https://prmaven.neoforged.net/NeoForge/pr1230'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1230.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1230
cd NeoForge-pr1230
curl -L https://prmaven.neoforged.net/NeoForge/pr1230/net/neoforged/neoforge/21.0.59-beta-pr-1230-bump-fml-ml/mdk-pr1230.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Technici4n
Copy link
Member

Note: CI is failing.

@Technici4n
Copy link
Member

Does updated Mixin already include the VirtualJar? That could be the cause of the CI failure.

@Matyrobbrt Matyrobbrt added 1.21 Targeted at Minecraft 1.21 bug A bug or error enhancement New (or improvement to existing) feature or request labels Jul 4, 2024
@shartte
Copy link
Contributor Author

shartte commented Jul 4, 2024

Raise another glass for module-land :D
neoforged/FancyModLoader#175

@Technici4n Technici4n merged commit e137f81 into neoforged:1.21.x Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Targeted at Minecraft 1.21 bug A bug or error enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants