From 3a63bef1d38ec4d1f23325785d4a7854e869f4ec Mon Sep 17 00:00:00 2001 From: shartte Date: Sun, 19 Nov 2023 14:34:38 +0100 Subject: [PATCH] Fail fast when a dependency replacement handler throws an unhandled exception. (#49) --- .../replacement/DependencyReplacementsExtension.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/common/src/main/java/net/neoforged/gradle/common/extensions/dependency/replacement/DependencyReplacementsExtension.java b/common/src/main/java/net/neoforged/gradle/common/extensions/dependency/replacement/DependencyReplacementsExtension.java index 238c8a478..fc16d3066 100644 --- a/common/src/main/java/net/neoforged/gradle/common/extensions/dependency/replacement/DependencyReplacementsExtension.java +++ b/common/src/main/java/net/neoforged/gradle/common/extensions/dependency/replacement/DependencyReplacementsExtension.java @@ -15,6 +15,7 @@ import net.neoforged.gradle.dsl.common.util.CommonRuntimeUtils; import net.neoforged.gradle.dsl.common.util.ModuleReference; import net.neoforged.gradle.util.TransformerUtils; +import org.gradle.api.GradleException; import org.gradle.api.NamedDomainObjectContainer; import org.gradle.api.Project; import org.gradle.api.artifacts.Configuration; @@ -143,9 +144,11 @@ void handleDependency(final Configuration configuration, final ModuleDependency break; } } catch (Exception exception) { - getProject().getLogger().info("Failed to process dependency replacement on handler: " + exception.getMessage(), exception); + throw new GradleException("Uncaught exception while processing replacement of dependency " + dependency.getGroup() + ":" + dependency.getName() + + " using handler " + handler + ": " + exception.getMessage(), exception); } } + if (!dependencyReplacementInformation.contains(dependency, configuration)) { dependencyReplacementInformation.put(dependency, configuration, candidate); }