Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync tasks for eclipse resources #108

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

Nightenom
Copy link
Contributor

@Nightenom Nightenom commented Jan 24, 2024

This adds small copy task (which depends on processResources) from build/resources/* to bin/*
Tested using vscode (using my vscode PR)
Not tested using eclipse

(disclaimer: I'm not confident with using delayed evaluation in gradle, but it works)

EDIT: aims to resolve neoforged/MDK#34, resolve #70

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

Update IdeRunIntegrationManager.java
@marchermans
Copy link
Contributor

Why is this needed and what specified the "bin" directory?

@Nightenom
Copy link
Contributor Author

Bin directory is from model EclipseModel.getClasspath().getDefaultOutputDir()

It is replacement for copyEclipseResources, also discussed on discord (can't find when though)

@marchermans marchermans enabled auto-merge (squash) February 6, 2024 10:53
@marchermans marchermans merged commit 98c5ca6 into neoforged:NG_7.0 Feb 6, 2024
1 check passed
@Nightenom Nightenom deleted the feature/eclipse-resources branch February 6, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants