Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: Fix parchment detection #236

Merged
merged 3 commits into from
Aug 14, 2024
Merged

[FIX]: Fix parchment detection #236

merged 3 commits into from
Aug 14, 2024

Conversation

marchermans
Copy link
Contributor

Parchment detection was broken due to using an "" string checking logic combined with circular reference processing with getIsEnabled on the none local properties of the subsystem

Closes: #235

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 13, 2024 •
edited
Loading

  • Publish PR to GitHub Packages

Last commit published: 60f2069e175588a7058be0e3b93c756123b7e09b.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #236' // https://github.com/neoforged/NeoGradle/pull/236
        url 'https://prmaven.neoforged.net/NeoGradle/pr236'
        content {
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle', 'test-utils')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
        }
    }
}

@marchermans marchermans enabled auto-merge (squash) August 13, 2024 20:25
@marchermans
Fix parchment not enabled detection
60f2069 
Add test to cover parchment usage
@marchermans marchermans merged commit cd10dca into NG_7.0 Aug 14, 2024
111 checks passed
@marchermans marchermans deleted the fix/parchment-enabled-detection branch August 14, 2024 09:37
@neoforged-releases
Copy link

🚀 This PR has been released as NeoGradle version 7.0.160.

@neoforged-releases neoforged-releases bot mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parchment not working in VSCode
1 participant
@marchermans