Switch to Gradles approach for serializing System properties #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpects the user to escape quotes themselves). Escape VM arguments passed to Eclipse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle expects the user to escape quotes in system properties themselves and relies on quoting the entire JVM argument that a system property is encoded as. (so
systemProperty "a b", "c d"is encoded as-Da b=c d, which is then quoted in its entirety).Also apply this quoting to VM arguments that are passed on to the Eclipse run configuration since the ECL library just joins VM arguments with spaces, without further quoting.