Streamline Inject Tasks for Neoforge in Userdev #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in addition to manipulating the task tree.
…taneously, each with their own filters. Use that new task to merge the injections from NeoForm and NeoForge userdev into a single task.
shartte
force-pushed
the
streamlined-inject-and-patch
branch
from
28b5073
to
181e27a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the individual download, unpack and inject tasks for Neoforge in Userdev and instead extends the Inject task to support multiple sources with individual filters, as well as sourcing files directly from a ZIP file. This allows us to pass the resolved artifact for Neoforge sources+resources directly to the Inject task and streamline+speed up the process.
Since injecting doesn't allow for existing files to be overwritten, adding this to the inject task (which runs before patch), should not affect patches.
Includes a prerequisite commit that may be reviewed separately: Add the ability to the runtime builder to customize individual tasks in addition to manipulating the task tree.