Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime data in an effort to reduce task inputs #76

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Dec 15, 2023

The current RuntimeData definition causes all runtime tasks to have an input-file dependency on every unpacked NeoForm file (~220 files).

Instead of converting the data section of the NeoForm config into File up-front, and passing that to the task, this only resolves the distribution-specific aspects of data and then passes through the resulting Map<String, String> to the task factories.

@marchermans marchermans merged commit 818fd14 into neoforged:NG_7.0 Dec 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants