Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Unify exception codes in Abstract(Template)View #3413

Open
wants to merge 2 commits into
base: 8.3
Choose a base branch
from

Conversation

kdambekalns
Copy link
Member

Exception codes are supposed to be unique, so this makes sure those places get a code of their own.

Upgrade instructions

If you rely on that exception code (1359625876) for whatever reason, consider taking the new codes into account, too:

  • 1359625877
  • 1359625878
  • 1359625879
  • 1359625880
  • 1359625881
  • 1359625882
  • 1359625883

Review instructions

You could check if any of the new codes is in use already, in turn… 😬

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Exception codes are supposed to be unique, so this makes
sure those four places get a code of their own.
@kdambekalns kdambekalns self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant