Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix constructor injection in NodeRedirectService #70

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

ahaeslich
Copy link
Member

Using #[Flow\inject] on a constructor parameter fails with Attribute "Neos\Flow\Annotations\Inject" cannot target parameter (allowed targets: property).

Using `#[Flow\inject]` on a constructor parameter fails with `Attribute "Neos\Flow\Annotations\Inject" cannot target parameter (allowed targets: property)`.
@ahaeslich ahaeslich requested a review from dlubitz March 16, 2024 09:45
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this had worked before. But maybe there where some Flow changes afterwards.

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@ahaeslich ahaeslich merged commit 36e59f7 into main Mar 16, 2024
2 of 3 checks passed
@mhsdesign mhsdesign deleted the bugfix/constructor-injection branch March 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants