Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and add some endpoints for review #171

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Fix and add some endpoints for review #171

merged 9 commits into from
Jul 8, 2024

Conversation

417-72KI
Copy link
Contributor

@417-72KI 417-72KI commented Jul 2, 2023

@417-72KI 417-72KI requested a review from pietbrauer July 2, 2023 20:16
@417-72KI
Copy link
Contributor Author

@pietbrauer
Do you have any concerns about merging this?

@pietbrauer
Copy link
Member

@417-72KI I think we should release a new request kit version first and then fix the FIXMEs, right?

@pietbrauer
Copy link
Member

@417-72KI RequestKit 3.3.0 was released. Sorry it took so long…

@417-72KI
Copy link
Contributor Author

417-72KI commented Jul 2, 2024

@pietbrauer
I updated RequestKit to new version and FIXMEs are gone! 🚀

pietbrauer
pietbrauer approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@pietbrauer pietbrauer merged commit a8290f7 into nerdishbynature:main Jul 8, 2024
9 checks passed
@417-72KI 417-72KI deleted the fix-review branch September 1, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietbrauer pietbrauer pietbrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@417-72KI @pietbrauer