Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API revamp #214

Merged
merged 12 commits into from
May 25, 2024
Merged

API revamp #214

merged 12 commits into from
May 25, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented May 21, 2024

Before:

server.add_gui_button()
server.add_gui_folder()
server.on_scene_click()
server.add_mesh()
server.reset_scene()

After:

server.gui.add_button()
server.gui.add_folder()
server.scene.on_click()
server.scene.add_mesh()
server.scene.reset()

Wrappers + deprecation warnings should be added if we decide to go with this change.

@brentyi brentyi force-pushed the main branch 11 times, most recently from 6ea47b3 to 7a6ab4a Compare May 25, 2024 07:14
@brentyi brentyi marked this pull request as ready for review May 25, 2024 13:40
@brentyi brentyi merged commit 400cafc into main May 25, 2024
9 checks passed
@brentyi brentyi deleted the brent/new_api branch May 25, 2024 13:41
brentyi added a commit that referenced this pull request Jul 9, 2024
@brentyi
API revamp (#214)
07e227c 
* Start API revamp

* URDF wrapper fixes

* Fixes

* Minor fixes, docs

* Caps

* Cleanup

* Add backwards compatibility shims

* Cleanup

* Docs

* Remove mypy, formatting

* Type alias fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brentyi