Fix dao related CI #585
Merged
Fix dao related CI #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval-exec
force-pushed
the
exec/increase-fee-rate
branch
7 times, most recently
from
6c0ec69
to
e95127b
Compare
Signed-off-by: Eval EXEC <execvy@gmail.com>
eval-exec
force-pushed
the
exec/increase-fee-rate
branch
from
e95127b
to
81fa55e
Compare
|
@doitian @EthanYuan Request for review. |
EthanYuan
reviewed
Mar 4, 2024
| @@ -48,6 +48,16 @@ impl Miner { | |||
| .expect("RPC generate_block") | |||
| } | |||
|
|
|||
| pub fn generate_epochs(&self, num_epochs: u64, epoch_length: u64) -> EpochNumberWithFraction { | |||
There was a problem hiding this comment.
If our dao tests are all integer multiples of epochs, for simplicity, it is suggested to remove the epoch_length parameter.
ckb_types::core::EpochNumberWithFraction::new(num_epochs, 0, 1)Can generate_blocks be removed?
There was a problem hiding this comment.
it is suggested to remove the epoch_length parameter
Ok, we can improve this later.
Can generate_blocks be removed?
generate_blocks can not be removed, many specs are using it.
EthanYuan
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
generate_epochsfor dao related integration test.