Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix spelling issues #224

Merged
merged 2 commits into from
Nov 28, 2024
Merged

docs: fix spelling issues #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bac699
Update migration-guide.md
nnsW3 Oct 8, 2024
73ba521
Update README.md
nnsW3 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ ckb-sdk-go provides a convenient client to help you easily interact with [CKB](h
```go
ckbClient, err := rpc.Dial("http://127.0.0.1:8114")
//!!NOTE:
// Indexer RPCs are now intergated into CKB, people now should directly use CKB clients, not the legacy indexer client
// Indexer RPCs are now integrated into CKB, people now should directly use CKB clients, not the legacy indexer client
// check https://github.com/nervosnetwork/ckb/blob/develop/rpc/README.md#module-indexer for equivalent RPCs
//indexerClient, err := indexer.Dial("http://127.0.0.1:8114")
mercuryClient , err := mercury.Dial("http://127.0.0.1:8116")
Expand Down Expand Up @@ -152,7 +152,7 @@ For more use cases of Mercury, please refer to [Mercury test cases](./mercury/cl
Once the `TransactionWithScriptGroups` is prepared, you can follow these steps to sign and send transaction to CKB network.

1. sign transaction with your private key.
2. send signed transaction to CKB node, and wait it to be confirmed.
2. send signed transaction to CKB node, and wait for it to be confirmed.

```go
// You can get txWithScriptGroups by manual or by mercury
Expand Down
4 changes: 2 additions & 2 deletions docs/migration-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ In the following part, we list the aspects you need to care about most if you ar

## Address

The new sdk remove struct `ParsedAddress` and `AddressGenerateResult`, and use a unified struct `Address` to represent ckb address. Below code is the example of address operations.
The new sdk removes struct `ParsedAddress` and `AddressGenerateResult`, and uses a unified struct `Address` to represent ckb address. Below code is an example of address operations.

Decode address

Expand Down Expand Up @@ -113,4 +113,4 @@ txWithScriptGroups, err := mercuryClient.BuildSimpleTransferTransaction(req)
txSigner := signer.GetTransactionSignerInstance(types.NetworkTest)
txSigner.SignTransaction(txWithScriptGroup, "0x6c9ed03816e31...")
txHash, err := ckbClient.SendTransaction(context.Background(), txWithScriptGroup.TxView)
```
```
Loading