feat: force small change as fee #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blckngm
commented
Jul 21, 2023
| * Add a potential input for the transaction. | ||
| * <p> | ||
| * The input may not be actually used if there's already enough capacity for the outputs. | ||
| */ |
There was a problem hiding this comment.
OT but this is really surprising. Do we want to change this so that these inputs are definitely used?
blckngm
changed the title
|
@quake PTAL. |
quake
reviewed
Jul 31, 2023
ckb/src/main/java/org/nervos/ckb/transaction/CkbTransactionBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Quake Wang <quake.wang@gmail.com>
blckngm
force-pushed
the
force-small-fee-as-change
branch
from
b87a8b9
to
0dba908
Compare
quake
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to existing design/implementation of change output, a change output must not be set when using this feature.Alternatively, we can change the change output implementation a bit and still add a change output when this option is used but the fee is not that small. WDYT?Change output is still supported when using forceSmallChangeAsFee.