Implement writev syscall in stdio #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musl actually uses writev instead of write syscall to print to stdout. Adding this new syscall implementation makes ckb-debugger nicer to musl. Note that musl actually issues ioctl before issuing writev syscall as well, however, ioctl is one messy component, it might be better that we keep it simple so the debugger only handles writev for now. We can hijack ioctl like we do now in musl.
XuJiandong
approved these changes
Jul 19, 2024
mohanson
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
musl actually uses writev instead of write syscall to print to stdout. Adding this new syscall implementation makes ckb-debugger nicer to musl. Note that musl actually issues ioctl before issuing writev syscall as well, however, ioctl is one messy component, it might be better that we keep it simple so the debugger only handles writev for now. We can hijack ioctl like we do now in musl.