fix: rare failing case in multisig (#98)

* fix: rare failing case in multisig * update docco to 0.9.1
nervosnetwork · Sep 10, 2024 · 9341664 · 9341664
1 parent a7b7c75
commit 9341664
Show file tree

Hide file tree

Showing 11 changed files with 565 additions and 536 deletions.
diff --git a/.npm/package-lock.json b/.npm/package-lock.json
diff --git a/.npm/package.json b/.npm/package.json
@@ -1,5 +1,5 @@
 {
   "dependencies": {
-    "docco": "=0.8.0"
+    "docco": "=0.9.1"
   }
 }
diff --git a/build.rs b/build.rs
@@ -27,7 +27,7 @@ const BINARIES: &[(&str, &str)] = &[
     ),
     (
         "secp256k1_blake160_multisig_all",
-        "43400de165f0821abf63dcac299bbdf7fd73898675ee4ddb099b0a0d8db63bfb",
+        "50c8623ef5112510ccdf2d8e480d02d0de7288eb9968f8b019817340c3991145",
     ),
 ];
 

diff --git a/c/secp256k1_blake160_multisig_all.c b/c/secp256k1_blake160_multisig_all.c
@@ -285,8 +285,8 @@ int main() {
   // Verify threshold signatures, threshold is a uint8_t, at most it is
   // 255, meaning this array will definitely have a reasonable upper bound.
   // Also this code uses C99's new feature to allocate a variable length array.
-  uint8_t used_signatures[threshold];
-  memset(used_signatures, 0, threshold);
+  uint8_t used_signatures[pubkeys_cnt];
+  memset(used_signatures, 0, pubkeys_cnt);
 
   // We are using bitcoin's [secp256k1 library](https://github.com/bitcoin-core/secp256k1)
   // for signature verification here. To the best of our knowledge, this is an unmatched