chore: Use as provided by mingw on Windows
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using clang (as a preprocessor) & yasm to transform assembly source code on Windows. On the one hand, this is really a hack solution to build a GAS-coupled assembly source file, on the other hand, yasm hasn't seen a proper release in years, making us believe that yasm is slowly becoming unmaintained. This change switches to use mingw when building the assembly source code, mingw is actively maintained now, which will reduce any problems we might run into. Note that we only activate the new logic when target environment is `msvc`, for `x86_64-pc-windows-gnu` target, current logic would already work flawlessly.
xxuejie
changed the title
xxuejie
changed the title
as provided by mingw on Windows
mohanson
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using clang (as a preprocessor) & yasm to transform assembly source code on Windows. On the one hand, this is really a hack solution to build a GAS-coupled assembly source file, on the other hand, yasm hasn't seen a proper release in years, making us believe that yasm is slowly becoming unmaintained. This change switches to use mingw when building the assembly source code, mingw is actively maintained now, which will reduce any problems we might run into.
Note that we only activate the new logic when target environment is
msvc, forx86_64-pc-windows-gnutarget, current logic would already work flawlessly.