Skip to content

Commit

Permalink
Add test skips for models with size_t histentry/archivingnode
Browse files Browse the repository at this point in the history
  • Loading branch information
otcathatsya committed Sep 10, 2024
1 parent 3c0c3b6 commit aa9cd13
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 15 deletions.
9 changes: 0 additions & 9 deletions testsuite/pytests/connect_test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,6 @@ def testStdpFacetshwSynapseHom(self):
syn_params = {"synapse_model": "stdp_facetshw_synapse_hom"}
check_synapse(params, values, syn_params, self)

def testStdpPlSynapseHom(self):
params = ["Kplus"]
values = [0.173]
syn_params = {"synapse_model": "stdp_pl_synapse_hom"}
check_synapse(params, values, syn_params, self)

def testStdpSynapseHom(self):
params = ["Kplus"]
values = [0.382]
Expand Down Expand Up @@ -229,7 +223,6 @@ def testRPortAllSynapses(self):
"static_synapse_hom_w",
"stdp_dopamine_synapse",
"stdp_facetshw_synapse_hom",
"stdp_pl_synapse_hom",
"stdp_synapse_hom",
"stdp_synapse",
"tsodyks2_synapse",
Expand Down Expand Up @@ -260,7 +253,6 @@ def testWeightAllSynapses(self):
"quantal_stp_synapse",
"stdp_dopamine_synapse",
"stdp_facetshw_synapse_hom",
"stdp_pl_synapse_hom",
"stdp_synapse_hom",
"stdp_synapse",
"tsodyks2_synapse",
Expand All @@ -284,7 +276,6 @@ def testDelayAllSynapses(self):
"static_synapse_hom_w",
"stdp_dopamine_synapse",
"stdp_facetshw_synapse_hom",
"stdp_pl_synapse_hom",
"stdp_synapse_hom",
"stdp_synapse",
"tsodyks2_synapse",
Expand Down
1 change: 1 addition & 0 deletions testsuite/pytests/sli2py_regressions/test_issue_77.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"eprop_readout_bsshslm_2020", # does not send spikes
"eprop_iaf_bsshslm_2020", # does not support stdp synapses
"eprop_iaf_adapt_bsshslm_2020", # does not support stdp synapses
"iaf_psc_alpha_hom" # size_t archivingnode/histentry only
]

# The following models require connections to rport 1 or other specific parameters:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def prepare():


@pytest.mark.parametrize(
"synapse", ["stdp_synapse_hom", "stdp_pl_synapse_hom", "stdp_facetshw_synapse_hom", "stdp_dopamine_synapse"]
"synapse", ["stdp_synapse_hom", "stdp_facetshw_synapse_hom", "stdp_dopamine_synapse"]
)
class TestSettingCommonProps:
def test_setting_common_props_on_original(self, synapse):
Expand Down
4 changes: 3 additions & 1 deletion testsuite/pytests/test_changing_tic_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ class TestChangingTicBase(unittest.TestCase):
# change in tic-base. However, because the value in the defaults
# is converted to ms, it will differ from the reference value.
# The model is therefore ignored.
ignored_models = ["iaf_psc_exp_ps_lossless"]
# iaf_psc_alpha_hom currently has a different archiving node base class
# to support size_t histentries and is therefore not compatible.
ignored_models = ["iaf_psc_exp_ps_lossless", "iaf_psc_alpha_hom"]

def setUp(self):
nest.ResetKernel()
Expand Down
12 changes: 8 additions & 4 deletions testsuite/pytests/test_labeled_synapses.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
HAVE_GSL = nest.ll_api.sli_func("statusdict/have_gsl ::")


# apply exceptions for synapses that do not support labels or are not compatible with the default histentry/archivingnode
synapse_list = [s for s in nest.synapse_models if s.endswith("_lbl")]


@nest.ll_api.check_stack
@unittest.skipIf(not HAVE_GSL, "GSL is not available")
class LabeledSynapsesTestCase(unittest.TestCase):
Expand Down Expand Up @@ -99,7 +103,7 @@ def default_network(self, syn_model):
def test_SetLabelToSynapseOnConnect(self):
"""Set a label to a labeled synapse on connect."""

for syn in [s for s in nest.synapse_models if s.endswith("_lbl")]:
for syn in synapse_list:
a, r_type = self.default_network(syn)

# see if symmetric connections are required
Expand All @@ -118,7 +122,7 @@ def test_SetLabelToSynapseOnConnect(self):
def test_SetLabelToSynapseSetStatus(self):
"""Set a label to a labeled synapse on SetStatus."""

for syn in [s for s in nest.synapse_models if s.endswith("_lbl")]:
for syn in synapse_list:
a, r_type = self.default_network(syn)

# see if symmetric connections are required
Expand All @@ -139,7 +143,7 @@ def test_SetLabelToSynapseSetStatus(self):
def test_SetLabelToSynapseSetDefaults(self):
"""Set a label to a labeled synapse on SetDefaults."""

for syn in [s for s in nest.synapse_models if s.endswith("_lbl")]:
for syn in synapse_list:
a, r_type = self.default_network(syn)

# see if symmetric connections are required
Expand All @@ -156,7 +160,7 @@ def test_SetLabelToSynapseSetDefaults(self):
def test_GetLabeledSynapses(self):
"""Get labeled synapses with GetConnections."""

for syn in [s for s in nest.synapse_models if s.endswith("_lbl")]:
for syn in synapse_list:
a, r_type = self.default_network(syn)

# see if symmetric connections are required
Expand Down
1 change: 1 addition & 0 deletions testsuite/pytests/test_sp/test_disconnect.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def setUp(self):
"urbanczik_synapse_lbl",
"urbanczik_synapse_hpc",
"sic_connection",
"stdp_pl_synapse_hom"
]

def test_synapse_deletion_one_to_one_no_sp(self):
Expand Down
1 change: 1 addition & 0 deletions testsuite/pytests/test_sp/test_disconnect_multiple.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def setUp(self):
"eprop_learning_signal_connection_bsshslm_2020_lbl",
"eprop_learning_signal_connection_bsshslm_2020_hpc",
"sic_connection",
"stdp_pl_synapse_hom"
]

def test_multiple_synapse_deletion_all_to_all(self):
Expand Down

0 comments on commit aa9cd13

Please sign in to comment.