Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move precise spike time offset from Event to Time class #2035

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Move precise spike time offset from Event to Time class #2035

wants to merge 9 commits into from

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented May 13, 2021 •
edited
Loading

Handle precise spike times by default in many places. This is done by moving the offset member from the Event to the Time class so that is always taken into account when calling Time::get_ms().

This means that plastic synapses will by default take precise spikes into account, so that the warnings added in #2137 can be removed again.

@clinssen clinssen added T: Discussion Still searching for the right way to proceed / suggestions welcome S: Normal Handle this with default priority I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 13, 2021
@clinssen clinssen marked this pull request as draft May 13, 2021 09:09
@clinssen clinssen mentioned this pull request Aug 30, 2021
Merged
clinssen pushed a commit to clinssen/nest-simulator that referenced this pull request Aug 30, 2021
move synaptic plasticity precise spike timing feature to nest#2035
fb9228d
@clinssen clinssen mentioned this pull request Aug 30, 2021
Merged
7 tasks
@clinssen clinssen mentioned this pull request Oct 6, 2021
Closed
@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Dec 15, 2021
@terhorstd
Copy link
Contributor

@clinssen, all mentioned PRs are either merged or closed. Would you be so kind as to comment on the current status of this work, and maybe provide a slightly better description? – Thanks! :)

@clinssen clinssen force-pushed the time-offset branch 2 times, most recently from 8ce8026 to 824a144 Compare December 1, 2022 11:07
@heplesser
Copy link
Contributor

@clinssen On my computer, unittests/model_node_init.sli gets stuck in your branch, while it passed on master. Does it also get stuck on your computer?

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Dec 3, 2022
@clinssen
Copy link
Contributor Author

clinssen commented Dec 5, 2022

model_node_init.sli passes, but my testsuite seems to get stuck (hanging) on regressiontests/issue-1703.py.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Feb 4, 2023
@JanVogelsang
Copy link
Contributor

Any updates on this PR?

@heplesser
Copy link
Contributor

@JanVogelsang This is high on my agenda, but I would like to integrate deliver-events-first before starting on this. I have a very elegant idea for it.

@heplesser heplesser mentioned this pull request Sep 11, 2023
Merged
@terhorstd
Copy link
Contributor

Any updates here?

@heplesser
Copy link
Contributor

Any updates here?

No, delayed due to higher-priority efforts, but not forgotten.

@clinssen clinssen mentioned this pull request Sep 9, 2024
Open
@otcathatsya otcathatsya self-requested a review September 10, 2024 07:28
@suku248 suku248 removed the request for review from otcathatsya September 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heplesser heplesser

Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Discussion Still searching for the right way to proceed / suggestions welcome
Projects
Kernel
Status: In progress
Models
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clinssen @terhorstd @heplesser @JanVogelsang