-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exponential lookup tables for homogenous STDP synapses #3247
Open
otcathatsya
wants to merge
12
commits into
nest:master
Choose a base branch
from
otcathatsya:exp_lookup_hom_stdp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Susanne Kunkel <su.kunkel@fz-juelich.de> Co-authored-by: Jari Pronold <jari.pronold@gmail.com>
JanVogelsang
added
S: Normal
Handle this with default priority
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: High
Should be handled next
and removed
S: Normal
Handle this with default priority
labels
Jul 9, 2024
otcathatsya
force-pushed
the
exp_lookup_hom_stdp
branch
from
July 12, 2024 11:25
e4b9e0e
to
96cd3b0
Compare
otcathatsya
force-pushed
the
exp_lookup_hom_stdp
branch
from
July 12, 2024 11:30
96cd3b0
to
1807697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: High
Should be handled next
T: Enhancement
New functionality, model or documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated implementation of lookup tables for exponential computations in homogenous STDP synapses (original commits by @suku248 @jarsi), for now just applied to
stdp_pl_synapse_hom
. There are a few potential concerns:Ideally we'd be able to keep
ArchivingNode
as a common base class and support both (potentially) precise spike times as well assize_t
-implemented grid steps, but due to the way history is stored this is impossible without costly conversion on multiple occasions. A dynamic polymorphism approach + conversions was implemented, but did considerably worse in benchmarks (albeit still better than the baseline, see figures below). For a simplified implementation, see: Make regular histentry step-based #3307Since we now require a separate archiving node (could be a static template impl but that also has minor overhead), we also need to duplicate the nodes that support homogenous STDP synapses; we introduced
iaf_psc_alpha_hom
. A better solution would probably require a restructuring for the way archivers are implemented, e.g. as pointers.In the figures below, "plain" is an implementation that just replaced existing structures for testing purposes while "separate" is the current version with duplicated classes, they are both listed as a sanity check and performance should be the same. "Converted" uses a templated histentry and conversion approach in archiving node. Std and mean values taken over 3 rng seeds.