Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boost detection and issue warning message #3285

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Update boost detection and issue warning message #3285

merged 2 commits into from
Aug 26, 2024

Conversation

heplesser
Copy link
Contributor

This PR fixes #3283 and fixes #3261.

  • Boost detection now uses the "CONFIG" scheme in CMake, see https://cmake.org/cmake/help/latest/policy/CMP0167.html and https://cmake.org/cmake/help/latest/command/find_package.html
  • This also hikes Boost requirements from 1.69 to 1.70 because the CONFIG scheme for Boost cam with 1.70. This seems unproblematic, as 1.70 was released in April 2019 and current Boost is 1.85.
  • The new approach only reports an error while CMake executes, positive Boost results are only presented in the summary. This seems to be a property of the CONFIG scheme.
  • A warning is printed if Boost is not found.
  • I also simplified version checking for GSL.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 8, 2024
gtrensch
gtrensch approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! Looks good to me. 👍

terhorstd
terhorstd approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@terhorstd terhorstd merged commit 589d7a7 into nest:master Aug 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Installation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake Boost detection changed Add warning for missing Boost similar to missing GSL
3 participants
@heplesser @terhorstd @gtrensch