Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Read the Docs warning about JavaScript search functionality #3295

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix Read the Docs warning about JavaScript search functionality #3295

merged 2 commits into from
Aug 21, 2024

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Aug 21, 2024 •
edited
Loading

This PR removes the jquery files from the repo and uses instead the CDN link in the template HTML.
This fixes the warning on the search page of Read the Docs regarding missing JavaScript

Also the particles* js files are removed since we do not use this anymore.

See Read the Docs result here: https://nest-simulator--3295.org.readthedocs.build/en/3295/search.html?q=clopath

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 21, 2024
steffengraber
steffengraber approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jessica-mitchell jessica-mitchell merged commit db9722e into nest:master Aug 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffengraber steffengraber steffengraber approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessica-mitchell @steffengraber