-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize computation in iaf_psc_alpha_ps model #3305
Conversation
Replace FP divides with FP multiplies and pre-compute loop invariants. Similar to nest#3304
@heshpdx Thank you for this improvement, a great gain for little work. Your PR also made me realize that I really need to post documentation on NEST model structure. Briefly So to make a long story short, the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heshpdx Thanks, all good now! One CI runner failed because a dependency could not be downloaded (SIONLIB). I have restarted the runner now.
@clinssen anything left for me to do here? |
Hi, thanks for the updates, this looks great and I'm giving it my thumbs up! |
Replace FP divides with FP multiplies and pre-compute loop invariants. Gives about +10% performance. Similar to #3304.