Adding support for unidirectional contracts #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #94 |
andbyrne
requested changes
Jun 20, 2024
andbyrne
requested changes
Jul 11, 2024
|
Please merge the latest commits from main, which should fix the CI workflow. |
andbyrne
requested changes
Jul 11, 2024
| @@ -73,23 +73,43 @@ variable "target_dscp" { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| variable "subjects" { | |||
| description = "List of contract subjects. Choices `action`: `permit`, `deny`. Default value `action`: `permit`. Choices `priority`: `default`, `level1`, `level2`, `level3`. Default value `priority`: `default`. Default value `log`: `false`. Default value `no_stats`: `false`. Choices `qos_class`: `unspecified`, `level1`, `level2`, `level3`, `level4`, `level5` or`level6`. Default value `qos_class`: `unspecified`. Choices `dscp_target` : `unspecified`, `CS0`, `CS1`, `AF11`, `AF12`, `AF13`, `CS2`, `AF21`, `AF22`, `AF23`, `CS4`, `AF41`, `AF42`, `AF43`, `CS5`, `VA`, `EF`, `CS6` `CS7` or a number between 0 and 63. Default value `dscp_target`: `unspecified`" | |||
There was a problem hiding this comment.
Add:
Default value `reverse_filter_ports`: `true`.
robvand
force-pushed
the
311
branch
3 times, most recently
from
a3404bd
to
cb69588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for unidirectional contracts in the aci_contracts module.
Modified subject attributes to include:
reverse_filter_ports
consumer_to_provider_service_graph
consumer_to_provider_qos_class
consumer_to_provider_target_dscp
consumer_to_provider_filters
provider_to_consumer_service_graph
provider_to_consumer_qos_class
provider_to_consumer_target_dscp
provider_to_consumer_filters
Directionally derived from presence of consumer_to_provider or provider_to_consumer_filters.