Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missing_device_type_components.py to check more than just names #77

Open
ryanmerolle opened this issue Jan 15, 2023 · 5 comments

Comments

@ryanmerolle
Copy link
Contributor

Update missing_device_type_components.py to check more than just names of items.

@ryanmerolle
Copy link
Contributor Author

@candlerb I started with this

Thoughts?

@danner26
Copy link
Member

Hey Ryan, just throwing this here as well since sometimes things get buried in slack.

Maybe you can build a hash table rather than using nested for loops? Data structures has never been my forte, but I do recall some of the math. Those 4 nested for loops are probably creating a lot of time complexity

@candlerb
Copy link
Contributor

Thoughts?

I think this should be a separate report, because there are two distinct things you might want to do:

  • Check for device components which are missing according to the device type template
  • Check for device components which are different from the device type template

That is: you may have intentionally changed something from the device type in a specific device, and don't want to be prompted about it all the time.

@ryanmerolle
Copy link
Contributor Author

That is: you may have intentionally changed something from the device type in a specific device, and don't want to be prompted about it all the time.

Good point. So a name focused Class like the original and a full detail Class.

@ryanmerolle
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants