MTC improvements on applying project cards #332
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Scalar values were different
2. MTC needed additional variables copied to managed lanes
3. Different foreign key for shapes
4. Scenario initiation from a Scenario instance OR a dictionary representing one
Co-authored-by: David Ory <david.ory@gmail.com>
- moved parameters from client.py to modules - added params to class instances - parameterized methods for non instance-level vars TODO: update all notebooks and usage.
Fixes network-wrangler#229 by making methods parameterizable and storing most client settings in RoadwayNetwork and TransitNetwork instance-level with good defaults rather than class-level variables. Also: - Added notebook testing - Some other clean up
- fixed typo bugs
- Allow new columns to be added wholesale - Also fixes network-wrangler#257
…rangler into generic_agency
…etwork_wrangler into generic_agency" This reverts commit 10631be, reversing changes made to c8213f9.
…sp-sag/network_wrangler into generic_agency"" This reverts commit 309d387.
when `managed` exists in the network (before applying the managed project card), and `managed` is not specified for newly added links (which can be assumed 0).
…roperty in project card
…ork_wrangler into generic_agency
(oops, committed too quickly)
1) disable automatic logging for all scripts through __init__.py; 2) add separate info and debug logging. See network-wrangler#286
|
@yueshuaing and @i-am-sijia : I believe this PR is now moot and can be closed? If there are any remaining items, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comparison purposes...