Update go to 1.23 #1193
Merged
Update go to 1.23 #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2024 14:22
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
…rade-go-1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Ex4amp1e
force-pushed
the
upgrade-go-1.23
branch
from
60670d4 to
a7e3353
Compare
added 2 commits
November 13, 2024 12:32
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
internal/vppinit/vppinit.go
Outdated
| @@ -140,11 +143,11 @@ func getKernelVer() ([2]int, error) { | |||
| if err != nil { | |||
| return [2]int{}, err | |||
| } | |||
| min, err := strconv.Atoi(ver[1]) | |||
| minValue, err := strconv.Atoi(ver[1]) | |||
There was a problem hiding this comment.
Suggested change
| minValue, err := strconv.Atoi(ver[1]) | |
| minor, err := strconv.Atoi(ver[1]) |
internal/vppinit/vppinit.go
Outdated
| if err != nil { | ||
| return [2]int{}, err | ||
| } | ||
| return [2]int{maj, min}, nil | ||
| return [2]int{maj, minValue}, nil |
There was a problem hiding this comment.
Suggested change
| return [2]int{maj, minValue}, nil | |
| return [2]int{major, minor}, nil |
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
denis-tingaikin
approved these changes
Nov 21, 2024
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Nov 21, 2024
…d-forwarder-vpp@main PR link: networkservicemesh/cmd-forwarder-vpp#1193 Commit: f2bf8fd Author: Vladislav Byrgazov Date: 2024-11-21 15:00:01 +0500 Message: - Update go to 1.23 (#1193) Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Nov 21, 2024
…d-forwarder-vpp@main (#12552) PR link: networkservicemesh/cmd-forwarder-vpp#1193 Commit: f2bf8fd Author: Vladislav Byrgazov Date: 2024-11-21 15:00:01 +0500 Message: - Update go to 1.23 (#1193) Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#12294