Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on Contributing - Needs Updating #209

Open
jvanderaa opened this issue Feb 7, 2023 · 5 comments
Open

Documentation on Contributing - Needs Updating #209

jvanderaa opened this issue Feb 7, 2023 · 5 comments

Comments

@jvanderaa
Copy link
Contributor

Environment

  • Python version: 3.x
  • circuit_maintenance_parser version: latest

Expected Behavior

I expected that the invoke tasks would allow for the testing

Observed Behavior

  • Errors due to no Dockerfile

Steps to Reproduce

  1. clone repo
  2. run invoke build
  3. Get error that Dockerfile was not present
@chadell
Copy link
Collaborator

chadell commented Feb 10, 2023

True, the library runs simple pytest testing without a container.

@csessh
Copy link
Contributor

csessh commented Feb 23, 2023

@jvanderaa

I made a quick update with this PR: #212

Does it look alright to you?

@slyngshede
Copy link
Contributor

slyngshede commented May 2, 2023

On macOS using Poetry to install will fail. I haven't debugged further, but building numpy fails, though I'm not sure what it is that Poetry is trying to install as it doesn't include a number of required packages like pytest.

Installing packages with pip in a virtualenv work fine:

pip install pydantic chardet geopy tzwhere backoff icalendar netconan invoke toml click lxml pytest
pytest --log-cli-level=DEBUG --capture=tee-sys -k test_parsers

@chadell
Copy link
Collaborator

chadell commented May 3, 2023

hi @slyngshede , which Poetry version are you using?

@slyngshede
Copy link
Contributor

@chadell You can ignore my comment, it was related to running Python 3.11 and newer versions of NumPy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants