-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture more content in parsed summary
for all parsers
#87
Comments
Optionally could add an entirely new field, |
The idea of the |
If nautobot/nautobot-app-circuit-maintenance#116 can be implemented to capture the email "body" rather than a truncated set of headers into the RawNotification, I think that would meet my needs as an alternative / better solution to this issue in general. Specifically, for Lumen notifications, I believe I've seen that we capture the "Summary" (which is the same across all updates to a scheduled maintenance) but not the "Updates" that are separately included in the email, for example:
I can verify this behavior and submit a PR for the Lumen parser specifically when I find some time to do so. |
I think that if the info that you are interested can be extracted from the notification, and stored in the object.summary it's always better, and it's relatively easy to do with a small change on the parser to take into account also the |
Environment
Proposed Functionality
All parsers should err on the side of including more information in the
summary
field versus trying to narrowly extract a single sentence or paragraph from the overall notification.Use Case
Notifications often include many additional details beyond what we're currently capturing in most
summary
fields. In integrating the output of this parser library with other systems, it's better to preserve information rather than discarding it.The text was updated successfully, but these errors were encountered: