Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to support pydantic 1 and 2 #281

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Add the ability to support pydantic 1 and 2 #281

merged 6 commits into from
Apr 4, 2024

Conversation

itdependsnetworks
Copy link
Contributor

No description provided.

chadell
chadell previously approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me

One comment (aside from the CI failing), is that for ease future clean up work, you could add comments on the code workaround to signal that this is for Pydantic 1.x, and should be removed when we drop support for it.

chadell
chadell approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell chadell merged commit 1cb6a18 into networktocode:develop Apr 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews is a code owner

@pke11y pke11y Awaiting requested review from pke11y pke11y is a code owner

@scetron scetron Awaiting requested review from scetron scetron is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itdependsnetworks @chadell