Fixes natural deletion order flag #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kircheneer
force-pushed
the
fix-natural-deletion-order
branch
4 times, most recently
from
edd3ecc
to
833ed62
Compare
Kircheneer
force-pushed
the
fix-natural-deletion-order
branch
from
833ed62
to
f3e5af9
Compare
chadell
reviewed
Nov 15, 2023
Kircheneer
force-pushed
the
fix-natural-deletion-order
branch
from
f3e5af9
to
ab94235
Compare
|
Will wait to see if this correctly addresses the issue by installing from this branch and merge only of it does. |
Prior to this change, if natural deletion order was set on a parent model and that model had no changes, children would not be recursed through.
Kircheneer
force-pushed
the
fix-natural-deletion-order
branch
from
ab94235
to
a5f035a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250 - see that for more information.