Adding support for Cisco ASA banner when nested underneath a parent config

netutils/config/parser.py

@@ -53,7 +53,7 @@ class BaseSpaceConfigParser(BaseConfigParser):
     # pylint: disable=abstract-method
 
     comment_chars = ["!"]
-    banner_start = ["banner", "vacant-message"]
+    banner_start = ["banner", "vacant-message", " banner", "  banner"]
 
     def __init__(self, config: str):
         """Create ConfigParser Object.
@@ -522,7 +522,7 @@ def _build_multiline_config(self, delimiter: str) -> t.Optional[ConfigLine]:
 class CiscoConfigParser(BaseSpaceConfigParser):
     """Cisco Implementation of ConfigParser Class."""
 
-    regex_banner = re.compile(r"^(banner\s+\S+|\s*vacant-message)\s+(?P<banner_delimiter>\^C|.)")
+    regex_banner = re.compile(r"^(banner\s+\S+|\s*vacant-message|\s*banner)\s+(?P<banner_delimiter>\^C|.)")
 
     def __init__(self, config: str):
         """Create ConfigParser Object.

tests/unit/mock/config/parser/base/cisco_asa/asa_nested_banner.txt

@@ -0,0 +1,3 @@
+group-policy PolicyName attribute
+ banner value If you are not authorized to use this system, disconnect now
+ banner value This system may be monitored or recorded

tests/unit/test_parser.py

@@ -2,6 +2,8 @@
 
 import glob
 import os
+import re
+from pathlib import Path
 
 import pytest
 from netutils.config import compliance
@@ -79,3 +81,29 @@ def test_duplicate_line():
     )
     with pytest.raises(IndexError, match=r".*This error is likely from a duplicate line detected.*"):
         compliance.parser_map["cisco_ios"](logging).config_lines  # pylint: disable=expression-not-assigned
+
+
+def test_cisco_nested_banner():
+    """Test Cisco ASA config parser with nested banner."""
+    current_dir = Path(__file__).parent
+    path_to_mock = "mock/config/parser/base/cisco_asa/"
+    mock_file_name = "asa_nested_banner.txt"
+    mock_file_full_path = Path.joinpath(current_dir, path_to_mock, mock_file_name)
+
+    with open(file=mock_file_full_path, mode="r", encoding="utf-8") as mock_file:
+        mock_content = mock_file.read()
+
+    asa_parser = compliance.parser_map["cisco_asa"](mock_content)
+    banner_lines = []
+    non_banner_lines = []
+    for line in mock_content.splitlines():
+        if re.match(pattern=r"^\s*banner", string=line):
+            banner_lines.append(line)
+        else:
+            non_banner_lines.append(line)
+
+    for line in banner_lines:
+        assert asa_parser.is_banner_start(line=line) is True
+
+    for line in non_banner_lines:
+        assert asa_parser.is_banner_start(line=line) is False