Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fortinet_get_system_interface.textfsm to new version 6.4 Fortinet #1594

Closed
wants to merge 2 commits into from

Conversation

GustavoMaga
Copy link
Contributor

Create the new match case to version 6.4 Fortinet.

Create the new match case to version 6.4 Fortinet.
@jmcgill298
Copy link
Contributor

@GustavoMaga Thanks for the PR, however, we will need the existing test case to pass, and we will also need either a new test case or an update to the existing test case to demonstrate correctly parsing with the 6.4 output.

@jmcgill298 jmcgill298 added the status: action required This issue requires additional information to be actionable label Jul 22, 2024
@mjbear
Copy link
Contributor

mjbear commented Aug 4, 2024

@GustavoMaga
As Jacob commented, the ntc-templates project requires all tests to pass for any change.

Additionally if support is added for output differences then raw CLI output has to be added as part of the pull request (PR). The test data allows the changes to be tested and confirmed against existing raw output as well as the new output via helper scripts.

I hope this helps.
Please respond back if there are questions.

@jmcgill298
Copy link
Contributor

@GustavoMaga are you still interested in seeing this PR completed?

@mjbear
Copy link
Contributor

mjbear commented Oct 11, 2024

@pnpestov
Might you also be willing to provide raw command output for this PR as well?

  • fortinet_get_system_interface

Though you might not have access to 6.4 anymore and the template may not need changed for this command on 7.0.
Thank you for any assistance you can provide here. 😀

@pnpestov
Copy link
Contributor

Might you also be willing to provide raw command output for this PR as well?

  • fortinet_get_system_interface

@mjbear
Unfortunately, I do not have access to version 6.4, but for 7.0.15 I attach the received data.
FortiGate-40F_get_system_interface.zip

@mjbear
Copy link
Contributor

mjbear commented Oct 11, 2024

Might you also be willing to provide raw command output for this PR as well?

  • fortinet_get_system_interface

@mjbear Unfortunately, I do not have access to version 6.4, but for 7.0.15 I attach the received data. FortiGate-40F_get_system_interface.zip

It took a moment for GitHub to refresh the thread for me. 🤷‍♂️
Thank you!
I'll work with that.

@pnpestov
Copy link
Contributor

It took a moment for GitHub to refresh the thread for me. 🤷‍♂️
Thank you!
I'll work with that.

Please, you are doing a very necessary and important thing.

@mjbear
Copy link
Contributor

mjbear commented Oct 12, 2024

closed by #1874

@jmcgill298 jmcgill298 closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: action required This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants