-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fortinet_get_system_interface.textfsm to new version 6.4 Fortinet #1594
Conversation
Create the new match case to version 6.4 Fortinet.
@GustavoMaga Thanks for the PR, however, we will need the existing test case to pass, and we will also need either a new test case or an update to the existing test case to demonstrate correctly parsing with the 6.4 output. |
@GustavoMaga Additionally if support is added for output differences then raw CLI output has to be added as part of the pull request (PR). The test data allows the changes to be tested and confirmed against existing raw output as well as the new output via helper scripts. I hope this helps. |
@GustavoMaga are you still interested in seeing this PR completed? |
@pnpestov
Though you might not have access to 6.4 anymore and the template may not need changed for this command on 7.0. |
@mjbear |
It took a moment for GitHub to refresh the thread for me. 🤷♂️ |
Please, you are doing a very necessary and important thing. |
closed by #1874 |
Create the new match case to version 6.4 Fortinet.