Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New template: Aruba Procurve show version #1862

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

evilmonkey19
Copy link
Contributor

@evilmonkey19 evilmonkey19 commented Oct 9, 2024

Personally, I don't know the difference between ArubaOS and Aruba Procurve. However, in the device i'm testing against using Netmiko, aruba_procurve works fine and aruba_os doesn't. 😅

@evilmonkey19 evilmonkey19 changed the title New template: Aruba OS show version New template: Aruba Procurve show version Oct 9, 2024
Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be hp_procurve?

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
@evilmonkey19
Copy link
Contributor Author

@evilmonkey19
Copy link
Contributor Author

It is fine to put into hp_procurve, but i want to use aruba_procurve as the platform. does it work in ntc_templates?

@jmcgill298
Copy link
Contributor

jmcgill298 commented Oct 9, 2024

It is fine to put into hp_procurve, but i want to use aruba_procurve as the platform. does it work in ntc_templates?

That can be done by changing the index file to use (hp|aruba)_procurve, but I suspect that might break are testing framework (should be fixable though)

@jmcgill298
Copy link
Contributor

@evilmonkey19 can you test evilmonkey19#2 to see if that works for you?

@evilmonkey19
Copy link
Contributor Author

During the weekend I will try to fix it :)

@evilmonkey19
Copy link
Contributor Author

evilmonkey19 commented Oct 11, 2024

In local development it works using the aruba_procurve platform if you do the little change in the index. Personally, I'm in favor of testing everything but in this case it is just a small change that would test the same result against the same platform. I don't have further testing should be required.

The testing suite is using the hp_procurve option and not the aruba_procurve, but the tests would be exactly the same in both cases.

TLDR: using aruba_procurve is the same as using hp_procurve

@jmcgill298 jmcgill298 merged commit 6f50dc7 into networktocode:master Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants