Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New template for NGFW FortiGate #1872

Merged
merged 15 commits into from
Oct 15, 2024
Merged

New template for NGFW FortiGate #1872

merged 15 commits into from
Oct 15, 2024

Conversation

pnpestov
Copy link
Contributor

The template for processing the command:
diagnose lldprx port neighbor details <port-name>

@pnpestov
Add files via upload
195b26d 
New Template: fortinet_diagnose_lldprx_port_neighbor_details_port-name.textfsm
@pnpestov
Update index
3c621cd 
fortinet_diagnose_lldprx_port_neighbor_details_port-name.textfsm, .*, fortinet, d[[iagnose]] lldpr[[x]] p[[ort]] n[[eighbor]] d[[etails]] (\S+)
@pnpestov
Create fortinet_diagnose_lldprx_port_neighbor_details_port-name.raw
70650b3
@pnpestov
Update fortinet_diagnose_lldprx_port_neighbor_details_port-name.raw
bcc35a4
@pnpestov
Add files via upload
b3a9003 
Create fortinet_diagnose_lldprx_port_neighbor_details_port-name.yml
jmcgill298
jmcgill298 requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pnpestov, just a couple of minor requets

ntc_templates/templates/fortinet_diagnose_lldprx_port_neighbor_details_port-name.textfsm Outdated Show resolved Hide resolved
ntc_templates/templates/fortinet_diagnose_lldprx_port_neighbor_details_port-name.textfsm Outdated Show resolved Hide resolved
ntc_templates/templates/fortinet_diagnose_lldprx_port_neighbor_details_port-name.textfsm Show resolved Hide resolved
...port_neighbor_details_port-name/fortinet_diagnose_lldprx_port_neighbor_details_port-name.yml Outdated Show resolved Hide resolved
@pnpestov
Copy link
Contributor Author

@jmcgill298
Thanks for the suggestions! I tried to convey the names of the variables in their original form. But if purposeful work is really underway to systematize the names, then your proposal is rational.

pnpestov and others added 4 commits October 11, 2024 08:14
@pnpestov @jmcgill298
Update ntc_templates/templates/fortinet_diagnose_lldprx_port_neighbor…
ec07b06 
…_details_port-name.textfsm


MAC -> MAC_ADDRESS

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
@pnpestov @jmcgill298
Update ntc_templates/templates/fortinet_diagnose_lldprx_port_neighbor…
d6e7272 
…_details_port-name.textfsm


Error Directive

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
@pnpestov @jmcgill298
Update ntc_templates/templates/fortinet_diagnose_lldprx_port_neighbor…
5e68491 
…_details_port-name.textfsm


MAC -> MAC_ADDRESS

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
@pnpestov @jmcgill298
Update tests/fortinet/diagnose_lldprx_port_neighbor_details_port-name…
d90aca7 
…/fortinet_diagnose_lldprx_port_neighbor_details_port-name.yml


mac -> mac_address

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
@pnpestov
Copy link
Contributor Author

@jmcgill298
"CI / yamllint (pull_request) Failing after 1m" - It is suspected that this is because of the character '\r\n' - adrienverge/yamllint#102 ?ysclid=m24s0ytu3361652791 What are my next steps?

@jmcgill298
Copy link
Contributor

@jmcgill298 "CI / yamllint (pull_request) Failing after 1m" - It is suspected that this is because of the character '\r\n' - adrienverge/yamllint#102 ?ysclid=m24s0ytu3361652791 What are my next steps?

We have provided scripts to help with this: https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_parser.md#development-helper-scripts

@jmcgill298
Copy link
Contributor

@pnpestov I created pnpestov#1

@pnpestov
Merge pull request #1 from jmcgill298/feature
c3064c3 
Fixup yaml file
@pnpestov
Update index
e66ff10 
Template name in length order (longest to shortest)
@jmcgill298 jmcgill298 merged commit 07db0d8 into networktocode:master Oct 15, 2024
14 checks passed
@pnpestov
Copy link
Contributor Author

@jmcgill298
Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnpestov @jmcgill298