Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail schema-enforcer validate when schema is not defined #46

Open
PhillSimonds opened this issue Nov 20, 2020 · 1 comment
Open

Fail schema-enforcer validate when schema is not defined #46

PhillSimonds opened this issue Nov 20, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@PhillSimonds
Copy link
Contributor

When a data file is mapped to a schema ID which does not exist, rather than exiting with an error code of 1 and printing a failure message to the screen, schema-enforcer prints a message to the screen indicating that all schema validation checks have passed when the command schema-enforcer validate is run. The non-existent schema IDs still show up when the command schema-enforcer validate --show-checks is run. Functionality should be implemented in the tool such that:

  • A log message is printed indicating that the referenced schema-id can not be found when the command schema-enforcer validate is run. The tool should also exit with a code of 1.
  • The same should occur when the schema-enforcer validate --show-checks or schema-enforcer validate --show-pass commands are run.
@PhillSimonds PhillSimonds self-assigned this Nov 20, 2020
@PhillSimonds PhillSimonds added the enhancement New feature or request label Nov 20, 2020
@dgarros dgarros added bug Something isn't working and removed enhancement New feature or request labels Nov 20, 2020
@dgarros
Copy link
Contributor

dgarros commented Nov 20, 2020

sounds like a bug to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants