Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP] find_child should return typed Control when tag allow #278

Open
Tracked by #304
netzulo opened this issue May 8, 2019 · 1 comment · May be fixed by #304
Open
Tracked by #304

[BP] find_child should return typed Control when tag allow #278

netzulo opened this issue May 8, 2019 · 1 comment · May be fixed by #304
Assignees
Labels
Awaiting-PR Work In Progress at some pull request Best Practice Not functionality problem, but refactor need it Testcase

Comments

@netzulo
Copy link
Owner

netzulo commented May 8, 2019

Obtained behaviour

For methods find_child/find_children can't return instance of ControlForm ControlTable ControlDropdown classes

Expected behaviour

For methods find_child/find_children can return instance of ControlForm ControlTable ControlDropdown classes

Notes

ctl = ControlBase(self.bot, **settings)

@netzulo netzulo added Best Practice Not functionality problem, but refactor need it Testcase labels May 8, 2019
@netzulo netzulo self-assigned this May 8, 2019
@netzulo
Copy link
Owner Author

netzulo commented Jun 7, 2019

Library it's limited at this point making redubdant import , maybe this functionality should exist at BotBase

@netzulo netzulo linked a pull request Feb 9, 2020 that will close this issue
7 tasks
@netzulo netzulo added the Awaiting-PR Work In Progress at some pull request label Feb 9, 2020
@netzulo netzulo linked a pull request Mar 15, 2020 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting-PR Work In Progress at some pull request Best Practice Not functionality problem, but refactor need it Testcase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant