Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onboarding introduction page that edits should be made by github or gitbook? #8

Closed
copperwiring opened this issue Jun 30, 2021 · 5 comments
Assignees
Labels
supporting infrastructure Scripts, CI, build tools, hosting

Comments

@copperwiring
Copy link

copperwiring commented Jun 30, 2021

As per todays discussion on slack, there seem to be two methods of editing gitbook:

There doesn't yet seem to be a consensus on which to use, however, the introduction page explicitly mentions GitHub.

This section includes information for getting started at NeuroPoly Lab. If you feel some information is missing, please feel free to edit this document or open a pull request on GitHub. Thank you! 🙏

It seems people have used both in the past. This can lead to confusions and conflicts if both mediums are used. Hence, we need to decide which of the two platform works seamlessly and update it accordingly

@copperwiring copperwiring assigned taowa and kousu and unassigned taowa Jun 30, 2021
@taowa
Copy link
Contributor

taowa commented Jul 6, 2021

My personal opinion here is that the gitbook can be our "official" way to edit pages, and that edits through the git repo can be "at your own risk". Someone editing with git should be able to rebase as needed to fix whatever it is they're doing when a conflict arises. If we decide that we don't want to be using git to make changes, I'd wonder why we're even using a platform like gitbook. I might suggest that we make the default branches protected though, so that pull requests are effectively required.

@copperwiring
Copy link
Author

Looping in @ahill187 as she had good insights on the relevant slack discussion.

@taowa
Copy link
Contributor

taowa commented Oct 6, 2021

I think that

My personal opinion here is that the gitbook can be our "official" way to edit pages, and that edits through the git repo can be "at your own risk". Someone editing with git should be able to rebase as needed to fix whatever it is they're doing when a conflict arises. If we decide that we don't want to be using git to make changes, I'd wonder why we're even using a platform like gitbook. I might suggest that we make the default branches protected though, so that pull requests are effectively required.

is the de facto way that we're doing this. Does anyone mind if I close this issue?

@kousu
Copy link
Member

kousu commented Oct 26, 2021

I have an opinion, which is to make Github the official way to edit: neuropoly/neuro.polymtl.ca#20 (comment), and to unprotect the branches.

I forgot this issue was open; I put the issue on the other repo because it concerns both repos. I'm going to close this; please give feedback on my plan on that issue!

@kousu kousu closed this as completed Oct 26, 2021
@kousu
Copy link
Member

kousu commented Nov 21, 2021

We've taken my approach in #21.

@kousu kousu added the supporting infrastructure Scripts, CI, build tools, hosting label Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
supporting infrastructure Scripts, CI, build tools, hosting
Projects
None yet
Development

No branches or pull requests

3 participants