Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use google slides instead of slideshare #56

Open
jcohenadad opened this issue Dec 16, 2021 · 7 comments
Open

Use google slides instead of slideshare #56

jcohenadad opened this issue Dec 16, 2021 · 7 comments

Comments

@jcohenadad
Copy link
Member

Pros:

  • easier to edit (on the fly, as opposed to going to the source, generate a new PDF, and upload on slideshare)

See example:
https://lukas-snoek.com/NI-edu/section_intros/2_glm.html

jcohenadad added a commit that referenced this issue Dec 16, 2021
Replaces old slideshare.
Related to #56
jcohenadad added a commit that referenced this issue Apr 5, 2022
Related to #56, #66
jcohenadad added a commit that referenced this issue Apr 5, 2022
@kousu
Copy link
Member

kousu commented Jun 21, 2022

This change makes these slides inaccessible to people using ad-blockers, like me, who don't want google tracking them in the normal course.

I'm okay connecting to docs.google.com if it's a direct connection where I'm consenting to it, but an embed isn't something I can consent to. My adblocker brings that consent back, but gives a stuttered experience to anyone using one. Embedding the PDFs avoided this.

@jcohenadad
Copy link
Member Author

jcohenadad commented Jun 22, 2022

This change makes these slides inaccessible to people using ad-blockers, like me, who don't want google tracking them in the normal course.
I'm okay connecting to docs.google.com if it's a direct connection where I'm consenting to it, but an embed isn't something I can consent to. My adblocker brings that consent back, but gives a stuttered experience to anyone using one. Embedding the PDFs avoided this.

wow, good to know. I wasn't aware you could not see the files with your ad-blocker. I am also using an ad-blocker and I can see the slides. Maybe because I'm using chrome? or because of the settings of the ad-blocker..?

image

@jcohenadad
Copy link
Member Author

jcohenadad commented Jun 22, 2022

ah! I'm connecting in incognito mode and observed this behaviour:
image

So yes, I agree with @kousu that relying on live-fetching of google content for our website might not be the best idea... Also considering countries where google content is less accessible.

EDIT 2022-07-25 19:10:18: After changing permissions (#56 (comment)) this issue is solved

@kousu
Copy link
Member

kousu commented Jun 23, 2022

I'm using uMatrix, which is maybe stricter than most adblockers, so maybe I'm an odd-duck out here, but when I migrated the site I tried to reduce the amount of third-party content to just make sure there were as few problems as possible, and also to make sure the site itself is as portable as possible -- it should render the same anywhere no matter whether we're looking at a local build, hosting on a demo site on readthedocs, on github pages, on godaddy, etc.

It actually took me quite a while to extract the PDFs from Slideshare -- since I didn't have the credentials to the Slideshare account. Once I finally found them I was embedding them locally in the site. But IMO the portability win made it worth it.

This arrangement does mean making edits to the PDFs requires three steps: 1. edit; 2. export; 3. upload them here to github under the right _media/ subfolder.

Maybe the edits you want to make to those PDFs could become pages on the site instead?

@kousu
Copy link
Member

kousu commented Jul 25, 2022

I just got this error page on the Google Slides version:

Screenshot_20220725_190014

@jcohenadad
Copy link
Member Author

@kousu I've changed the permissions-- is it working now?

@kousu
Copy link
Member

kousu commented Jul 25, 2022

Yes, it's back now.

Are you open to the idea of putting the PDFs back? They're more reliable because they make the site self-contained: it would look the same on GitHub Pages, GoDaddy, locally, and from Canada, Iran, China, or Australia, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants