Chore: more dex event attributes #707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0n00gler
previously approved these changes
Sep 4, 2024
pr0n00gler
reviewed
Sep 6, 2024
x/dex/types/events.go
Outdated
Comment on lines
229
to
248
| sdk.NewAttribute(AttributeTokenInAmountOut, amountOutMaker.String()), | ||
| sdk.NewAttribute(AttributeTokenOutAmountOut, amountOutTaker.String()), | ||
| sdk.NewAttribute(AttributeTokenInAmountOut, amountOutMaker.String()), |
There was a problem hiding this comment.
I think changes in the order of events can bring a lot of confusion for indexers.
Maybe we should keep the same order for them?
pr0n00gler
dismissed
their stale review
see comments above about events order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional dex event attributes for better indexing (p2p) and frontend integration.
PlaceLimitOrder:
SwapAmountInSwapAmountOutWithdrawFilledLimitOrder:
TokenInAmountOutTokenOutAmountOut(matches CancelLimitOrder)
Also adds new TrancheUserUpdateEvent