FEAT: Allow cancel inactive limit orders #711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please attach a succesfull testrun |
sotnikov-s
reviewed
Sep 10, 2024
x/dex/keeper/cancel_limit_order.go
Outdated
| @@ -59,20 +59,20 @@ func (k Keeper) ExecuteCancelLimitOrder( | |||
| ) (makerCoinOut, takerCoinOut sdk.Coin, tradePairID *types.TradePairID, error error) { | |||
| trancheUser, found := k.GetLimitOrderTrancheUser(ctx, callerAddr.String(), trancheKey) | |||
| if !found { | |||
| return sdk.Coin{}, sdk.Coin{}, nil, types.ErrActiveLimitOrderNotFound | |||
| return sdk.Coin{}, sdk.Coin{}, nil, types.ErrValidLimitOrderTrancheNotFound | |||
There was a problem hiding this comment.
according to the error definition, it's a wrapped error supposed to be here, isn't it? Here and at the line 75. Just like below at the line 88
quasisamurai
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow inactive limit orders to be canceled instead of withdrawn.
This new behavior has 2 benefits.
related PRs
neutron-org/neutron-integration-tests#355